Update versions and switch build system #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o pip from pyproject.toml
|
yo @cjbattey! thanks for doing this. I'll definitely look through it in the next day or so. seems like a lot of code moved here-- mostly auto-reformatting? |
|
Thanks! Yes, almost all black reformat and build stuff. popvae.py also moved to the top level directory to work with the new build system. But there were no changes in popvae.py code other than import commands to work with a newer Keras version. |
andrewkern
requested changes
Apr 5, 2024
There was a problem hiding this comment.
I hit an error running the test example using the --seed flag. I think it's a simple enough fix @cjbattey
|
@andrewkern oops, sorry about that. Fixed now, and I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates python, all dependency versions, the build system, and installation instructions to address #22. This setup worked for a fresh install on an M3 MacBook, using mamba for the virtual environment. There are no changes to analytical code.
Sorry about the size of the PR -- it's mostly build stuff and
blackreformatting the code. The relevant changes for installation are switchingsetup.pytopyproject.toml, README updates, and some minor refactors ofplotvae.pyto work with a newer version ofbokeh.Changes:
python setup.py installtopip install ./for package installationI tried to get this working with smaller tweaks I think five separate times and kept getting sucked in to more and more confusing dependency issues. But python 3.7 and tensorflow 1 are old enough to be dropping off pip, so have to update. I think (hope) this one will work.
@andrewkern , any chance you or someone in the lab could give this a shot and see if they can install and run the test data?