Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "cmake-native.bbclass: Add ubfs specific variable to ignore list" #887

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

kraj
Copy link
Owner

@kraj kraj commented Nov 22, 2023

The problem is in BSP layer [1], these variable should not be exported universally moreover its not needed as well.

[1] varigit/meta-variscite-bsp-imx#36 This reverts commit 288f752.


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

The problem is in BSP layer [1], these variable should not be exported
universally moreover its not needed as well.

[1] varigit/meta-variscite-bsp-imx#36
This reverts commit 288f752.
@kraj kraj merged commit 8aaed8f into kraj:master Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant