Rename generic plant nuclear model for paper submission #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove `confocal_3D_unet_ovules_nuclei_ds1x` as requested by Athul.
|
Hey @wolny @lorenzocerrone I am merging this PR without your review under the pressure of submitting the manuscript. We can add the old model back and think about alias afterwards. I'll create a tag for the latest changes if I can, just for updating the installation guide for the submission. |
|
Hi @qin-yu I think it's fine as is, no need for aliases IMO :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlantSeg_3Dnuc_platinum#192Hey @lorenzocerrone @wolny, do you think we can have alias for models? Our new nuclear model is named as PlantSeg_3Dnuc_platinum in the paper, but it doesn't really fit into the zoo and it's not even clear that it's a nuclear model.