Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update main.go #420

Closed
wants to merge 1 commit into from
Closed

Conversation

donatik27
Copy link

Changed log.Fatal to log.Fatalf in kroma-bindings/gen/main.go where string formatting is used:

  • log.Fatal("error reading contract list: %w\n", err)
  • log.Fatalf("error reading contract list: %w\n", err)
  • log.Fatal("error parsing contract list: %w\n", err)
  • log.Fatalf("error parsing contract list: %w\n", err)

Reason: When using format specifiers (%w, %v, etc.), log.Fatalf must be used instead of log.Fatal to properly format the error messages. This ensures correct error reporting and debugging.

Note: log.Fatal("must provide -monorepo-base") remains unchanged as it doesn't use format specifiers.

@donatik27 donatik27 requested a review from a team as a code owner January 23, 2025 16:54
Copy link
Contributor

coderabbitai bot commented Jan 23, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • kroma-bindings/gen/main.go is excluded by !**/gen/**, !**/gen/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Pangssu
Copy link
Contributor

Pangssu commented Jan 23, 2025

Please rename your commits and PRs to match the rules.
See the links below for the rules for commit and PR names.

@donatik27
Copy link
Author

Please rename your commits and PRs to match the rules. See the links below for the rules for commit and PR names.

Done

seolaoh
seolaoh previously approved these changes Jan 24, 2025
@seolaoh seolaoh changed the title Changed log.Fatal to log.Fatalf chore: changed log.Fatal to log.Fatalf Jan 24, 2025
@seolaoh
Copy link
Contributor

seolaoh commented Jan 24, 2025

Please update your commit to chore: update main.go.

@seolaoh seolaoh dismissed their stale review January 24, 2025 04:45

Commit title should follow semantic rules

@donatik27 donatik27 changed the title chore: changed log.Fatal to log.Fatalf chore: update main.go Jan 24, 2025
@donatik27
Copy link
Author

Please update your commit to chore: update main.go.

Done

@donatik27 donatik27 requested a review from seolaoh January 24, 2025 04:54
@seolaoh
Copy link
Contributor

seolaoh commented Jan 24, 2025

Please update your commit to chore: update main.go.

Done

I meant the "commit" message.

@donatik27
Copy link
Author

#427

Done

@donatik27 donatik27 closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants