fix: NoticeService#convertBaseUrl 로직 수정

ku-ring · Mar 18, 2023 · 391db2e · 391db2e
1 parent c81b5d1
commit 391db2e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/main/java/com/kustacks/kuring/kuapi/CategoryName.java b/src/main/java/com/kustacks/kuring/kuapi/CategoryName.java
@@ -24,6 +24,10 @@ public enum CategoryName {
         this.korName = korName;
     }
 
+    public boolean isSameName(String name) {
+        return this.name.equals(name);
+    }
+
     public boolean isSameShortName(String shortName) {
         return this.shortName.equals(shortName);
     }

diff --git a/src/main/java/com/kustacks/kuring/notice/business/NoticeService.java b/src/main/java/com/kustacks/kuring/notice/business/NoticeService.java
@@ -112,8 +112,8 @@ private String convertShortNameIntoLongName(String typeShortName) {
                 .orElseThrow(CategoryNotFoundException::new);
     }
 
-    private String convertBaseUrl(String type) {
-        return CategoryName.LIBRARY.isSameShortName(type) ? libraryBaseUrl : normalBaseUrl;
+    private String convertBaseUrl(String categoryName) {
+        return CategoryName.LIBRARY.isSameName(categoryName) ? libraryBaseUrl : normalBaseUrl;
     }
 
     private List<Notice> getNoticesBySubjectOrCategory(String[] keywords) {