Skip to content

Commit

Permalink
ui: status: hide pass results in contest breakdown of fails
Browse files Browse the repository at this point in the history
Hide pass results when we display contest (full result list)
for a branch for which some tests have failed. Majority of
the time this link is used to see what failed, so showing
passes just adds noise.

Signed-off-by: Jakub Kicinski <[email protected]>
  • Loading branch information
kuba-moo committed Aug 17, 2024
1 parent 092b26e commit afd7786
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions ui/status.js
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,8 @@ function add_summaries(table, summary, reported)
link_to_contest += "&pw-n=0";
else
link_to_contest += "&pw-y=0";
if (summary["fail"] + summary["skip"] > 0)
link_to_contest += "&pass=0";
link_to_contest += "\">" + str_psf.str + "</a>";

cell = row.insertCell(i++); // tests
Expand Down Expand Up @@ -671,6 +673,8 @@ function load_result_table_one(data_raw, table, reported, avgs)
link_to_contest += "&pw-n=0";
else
link_to_contest += "&pw-y=0";
if (fail + skip > 0)
link_to_contest += "&pass=0";
link_to_contest += "\">";

cnt.innerHTML = link_to_contest + str_psf.str + "</a>";
Expand Down

0 comments on commit afd7786

Please sign in to comment.