Pr 203 #297
ci.yml
on: pull_request
Run rustfmt
13s
Run clippy
55s
Matrix: cargo-test
Annotations
1 error and 4 warnings
cargo-test (ubuntu-latest)
Process completed with exit code 101.
|
this `if let` can be collapsed into the outer `if let`:
src/analyzer.rs#L456
warning: this `if let` can be collapsed into the outer `if let`
--> src/analyzer.rs:456:9
|
456 | / if let JSONSchemaPropsOrArray::Schema(props) = &items {
457 | | if let Some(p) = &props.properties {
458 | | let type_ = p.get("type");
459 | | let status = p.get("status");
... |
468 | | }
469 | | }
| |_________^
|
help: the outer pattern can be modified to include the inner pattern
--> src/analyzer.rs:455:17
|
455 | if let Some(items) = &value.items {
| ^^^^^ replace this binding
456 | if let JSONSchemaPropsOrArray::Schema(props) = &items {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
= note: `#[warn(clippy::collapsible_match)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/analyzer.rs#L275
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/analyzer.rs:275:78
|
275 | if !cfg.no_condition && key == "conditions" && is_conditions(&value) {
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
Run clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Run clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|