Replace ConfigMap reloader #2698
Conversation
…onfig-reloader Signed-off-by: chipzoller <[email protected]>
There was a problem hiding this comment.
LGTM! thanks, we'll run normal suite against this @LastJedionEarth
|
I'll leave this open another day or so giving others to weigh in on if there are other considerations prior to merging. |
|
Looks good! This PR only affects the Thanks @chipzoller for testing by making a change to the configmap and watching a reload! Biggest risk here is if the new image |
…etl-utils-pod * commit 'b675a8cacaa5b6c64cf00d3583df026cfc2ec507': (28 commits) exec (#2701) swap jimmidyson/configmap-reload for prometheus-operator/prometheus-config-reloader (#2698) update savedReports and advancedReports in values.yml to reflect current filter schema add systemProxy env vars (#2687) feat(cost-analyzer): add StatefulSet as option (#2188) [Feature] Development guide and devcontainers (#2680) Bump actions/checkout from 4.1.0 to 4.1.1 (#2683) remove replicasets from core (#2678) networkCosts service discovery (#2677) Begin Helm testing (#2674) update securityContexts (#2669) consistent image name for aggregator (#2676) Add version matrix and more tests (#2664) label consistency (#2673) setting to 50h to match etl retention time (#2667) pv sizing proxy for wf add missing bracket add ability to override cc sa name Added /savings/localLowDisks proxy for Aggregator. update perms (#2662) ...
|
@cliffcolvin @jessegoodier Do we want this in v1.107? If so we should cherry pick. |
…onfig-reloader (#2698) Signed-off-by: chipzoller <[email protected]>
|
FYI #2762 |
Signed-off-by: chipzoller [email protected]
What does this PR change?
Replaces the previous ConfigMap reloader with the Prometheus operator's official reloader.
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
No user impact. This is an under-the-hood swap out.
Links to Issues or tickets this PR addresses or fixes
GTM-71 (internal Kubecost)
What risks are associated with merging this PR? What is required to fully test this PR?
ConfigMap reloading might not happen upon change of the source.
How was this PR tested?
Tested locally. Changed resource
configmap/kubecost-prometheus-server, tailed logs, observed reloader.Have you made an update to documentation? If so, please provide the corresponding PR.