Minor template fixes #2735
Merged
Minor template fixes #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chipzoller <[email protected]>
Signed-off-by: chipzoller <[email protected]>
Signed-off-by: chipzoller <[email protected]>
Signed-off-by: chipzoller <[email protected]>
Signed-off-by: chipzoller <[email protected]>
Signed-off-by: chipzoller <[email protected]>
thomasvn
reviewed
Nov 8, 2023
|
@chipzoller Thanks for these improvements! Was there a tool you used to spot these issues? |
|
Some of them I find when templating the chart and piping the resulting YAML into VS Code to be validated by the K8s extension, and some are just old-fashion eagle eyes. |
thomasvn
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Makes minor adjustments to templates to fix invalid outputs addressing things like null/empty string fields, empty structs, or resources which are (basically) empty. These fixes make it so that the fully rendered output is conformant for Kubernetes linters. Two of the most visible changes:
+00:00(adopted from EKS values) whereas previously the env var was set with an empty value.Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
No user impact
Links to Issues or tickets this PR addresses or fixes
What risks are associated with merging this PR? What is required to fully test this PR?
Change has an unintended consequence.
How was this PR tested?
Templated locally for each change.
Have you made an update to documentation? If so, please provide the corresponding PR.