Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hideDiagnostics / hideOrphanedResources #2739

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

jessegoodier
Copy link
Collaborator

@jessegoodier jessegoodier commented Nov 8, 2023

What does this PR change?

Update #2651: format as json, add option to hideOrphanedResources

Does this PR rely on any other PRs?

https://github.com/kubecost/kubecost-frontend/pull/544

How does this PR impact users? (This is the kind of thing that goes in release notes!)

  • Limited support
  • Adds option to hideDiagnostics and/or hideOrphanedResources.
  • hideOrphanedResources hides the savings card. This card depends on Kubecost having access to the cloud services and is currently slow in large environments. There is a long-term change being discussed.

Links to Issues or tickets this PR addresses or fixes

What risks are associated with merging this PR? What is required to fully test this PR?

Next to none, simple change.

How was this PR tested?

helm template kubecost ./cost-analyzer --set kubecostFrontend.hideOrphanedDiagnostics=true >.idea/hideorph.yaml
helm template kubecost ./cost-analyzer --set kubecostFrontend.hideDiagnostics=true >.idea/hidediag.yaml

and compare changes.
We also have a live POC running.

Have you made an update to documentation? If so, please provide the corresponding PR.

updated helm values, otherwise will not be documented.

@jessegoodier jessegoodier marked this pull request as ready for review November 8, 2023 12:47
@jessegoodier jessegoodier enabled auto-merge (squash) November 8, 2023 12:48
@jessegoodier jessegoodier merged commit 42a0d72 into develop Nov 8, 2023
11 checks passed
@jessegoodier jessegoodier deleted the nginx-diagnostics-hide2 branch November 8, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants