multi-cluster-diagnostics pod #2780
Conversation
Signed-off-by: chipzoller <[email protected]>
Co-authored-by: Chip Zoller <[email protected]>
* thanos images update
There was a problem hiding this comment.
Tests failing as of these changes because kubecostProductConfigs is currently in a commented-out state. If diagnostics must be enabled by default, then kubecostProductConfigs.clusterName must be enabled by default.
if you see this:
https://github.com/kubecost/cost-analyzer-helm-chart/pull/2780/files#diff-f6d5a9ddec47ad0c6043e1a7258057f261cc6a135446693326d5cd4d27fc1497R124
diagnostics are only enabled if federation is enabled. if federation is enabled, you must set a cluster name.
|
Let me know what you help you need on this re: documentation |
|
Should we change this PR to a draft until the dependencies are merged? |
Yes |
Pull request was converted to draft
|
@jessegoodier @chipzoller I've cleaned this up a bit, and believe it's ready for review! Code for the diagnostics backend has been merged. |
|
@thomasvn this is good by me. mind approving? |
|
/cherry-pick v1.108 |
* diagnostics deployment Signed-off-by: chipzoller <[email protected]> Co-authored-by: thomasvn <[email protected]> Co-authored-by: Chip Zoller <[email protected]>
* diagnostics deployment Signed-off-by: chipzoller <[email protected]> Co-authored-by: thomasvn <[email protected]> Co-authored-by: Chip Zoller <[email protected]>
|
Forgot to label this. |
| ## Ref: https://docs.kubecost.com/install-and-configure/install/diagnostics | ||
| ## | ||
| diagnostics: | ||
| enabled: true |
There was a problem hiding this comment.
This doesn't look disabled by default.
There was a problem hiding this comment.
We had some conversations with product and engineering and the thought was launch and learn.
I do feel that the risk is low and the potential benefit is high.
There was a problem hiding this comment.
Can I suggest updating the values comment then so it's not confusing?
What does this PR change?
Creates a new diagnostic deployment for monitoring health in multi-cluster Kubecost environments
Does this PR rely on any other PRs?
KCM PR: https://github.com/kubecost/kubecost-cost-model/pull/1922
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Creates a new "diagnostics" deployment that has two functions:
More information available on our docs (link TBD)
Links to Issues or tickets this PR addresses or fixes
NA
What risks are associated with merging this PR? What is required to fully test this PR?
Minimal risk. we are using this internally for a month now.
How was this PR tested?
Many QA deployments
Have you made an update to documentation? If so, please provide the corresponding PR.
We will have a doc by GA.