fix: grafana dashboard templating #3826
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tarun Gupta Akirala <[email protected]>
|
Ping @jessegoodier @ivankube @cliffcolvin PTAL 🙏 |
Signed-off-by: Tarun Gupta Akirala <[email protected]>
|
@jessegoodier can you ptal at this - I would love to get this cherry picked into 2.6 branch for next rc cut if that's acceptable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
When i install kubecost helm chart with an external grafana, some dashboards are created with hardcoded uid's for datasources which makes grafana error out when loading the panels. See example
This change parametrizes the uid for datasource. We already do this in other dashboards which are working as expected. I copied the parameterization from other working dashboards.
See https://kubecost.slack.com/archives/CLFV60Y90/p1737446014836879 for more context
After applying the fixes from this PR, i was able to browse the dashboards correctly:
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Fixes some broken templating in grafana dashboards
Links to Issues or tickets this PR addresses or fixes
https://kubecost.slack.com/archives/CLFV60Y90/p1737446014836879
https://kubecost.atlassian.net/servicedesk/customer/portal/3/SUP-6670
What risks are associated with merging this PR? What is required to fully test this PR?
Install kubecost with grafana sidecar and dashboards will fail out of the box. Update the dashboard configmaps to see the error get resolved
How was this PR tested?
I updated the grafana dashboard configmaps manually which fixed the invalida datasource error
Have you made an update to documentation? If so, please provide the corresponding PR.
No