Cleanup blockCheckers #1016
Merged
Cleanup blockCheckers #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evrardjp
force-pushed
the
fix_small_memleak
branch
from
1bbb7bc to
97d755c
Compare
jonaz
reviewed
Nov 6, 2024
evrardjp
force-pushed
the
fix_small_memleak
branch
from
97d755c to
ba36c64
Compare
There is no need to continuously reallocate the check blockers. They only need to be defined once. Signed-off-by: Jean-Philippe Evrard <[email protected]>
evrardjp
force-pushed
the
fix_small_memleak
branch
from
ba36c64 to
e370b0b
Compare
dholbach
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until #1015 is merged.
There is no need to continuously reallocate the check blockers.
They only need to be defined once.