feat: add drain delay #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any idea why the E2E for 1.27 is failing? is it a transient problem - can we retry the job? |
|
Sometimes single test-run's are failing. This is unrelated to your changes. |
ckotzbauer
approved these changes
Nov 16, 2023
This was referenced Nov 16, 2023
|
I've opened two additional PR to add the flag to the configuration properties and parameter docs. |
ckotzbauer
approved these changes
Nov 18, 2023
Signed-off-by: Daniel Malon <[email protected]>
jackfrancis
force-pushed
the
feat/drain-delay
branch
from
14d2bcd to
2c1be3c
Compare
|
@MerlinDMC FYI I rebased on top of main and force-pushed to attempt to overcome unexplained E2E errors. Will merge when we get a green signal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--drain-delayflag.The duration given will delay the node draining process to allow for other controllers in the cluster to complete work.
We are using
--pre-reboot-node-labels=node.kubernetes.io/exclude-from-external-load-balancers=trueto signal the load balancer controller to start draining connections from the node as it is about to be drained.With the flag added we can delay the draining process to ensure the load balancer controller has enough time to remove the node from active traffic flow before the draining starts.