Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dashboard uid overriding by grafanaDashboardIDs map #937

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix dashboard uid overriding by grafanaDashboardIDs map #937

merged 1 commit into from
May 24, 2024

Conversation

oik741
Copy link
Contributor

@oik741 oik741 commented May 23, 2024 •
edited
Loading

Resolved #936

@rgeyer rgeyer mentioned this pull request May 23, 2024
Closed
rgeyer
rgeyer approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@rgeyer rgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We for sure should have caught this while updating the dashboards to grafonnet. 🤦‍♂️

@povilasv povilasv merged commit de834e9 into kubernetes-monitoring:master May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgeyer rgeyer rgeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes in grafanaDashboardIDs map doesn't take effect
3 participants
@oik741 @rgeyer @povilasv