Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack utility added #86

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Hack utility added #86

merged 2 commits into from
Jan 13, 2022

Conversation

Madhan-SWE
Copy link

@Madhan-SWE Madhan-SWE commented Jan 13, 2022 •
edited
Loading

Hack utility added to

  • update gomock
  • update gomod
  • verify gofmt
  • verify gofmt
  • verify vendor
  • verify covet

@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 13, 2022
mkumatag
mkumatag requested changes Jan 13, 2022
View reviewed changes
hack/update-gofmt Outdated Show resolved Hide resolved
hack/verify-govet Outdated Show resolved Hide resolved
pkg/driver/controller_test.go Outdated Show resolved Hide resolved
@mkumatag mkumatag added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 13, 2022
mkumatag
mkumatag approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2022
@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Madhan-SWE,mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 5816832 into kubernetes-sigs:main Jan 13, 2022
@Madhan-SWE Madhan-SWE linked an issue Jan 18, 2022 that may be closed by this pull request
Add additional features in Makefile, add hack script(util) #20
Closed
7 tasks
@Madhan-SWE Madhan-SWE mentioned this pull request Feb 18, 2022
Closed
9 tasks
kishen-v pushed a commit to kishen-v/ibm-powervs-block-csi-driver that referenced this pull request Jul 25, 2024
@openshift-merge-bot
Merge pull request kubernetes-sigs#86 from kishen-v/main-openshift
aaa6afa 
MULTIARCH-4809: Rebase with upstream: go modules updates and code changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add additional features in Makefile, add hack script(util)
4 participants
@Madhan-SWE @ppc64le-cloud-bot @mkumatag @rcmadhankumar