Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add more scheduler logging for pods #1949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

Add more scheduling logging to capture progress on creating nodeclaims in the cluster for long scheduling loops and add details on how many pods are in a terminating state in the debug logs

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2025
@jonathan-innis jonathan-innis force-pushed the add-more-scheduler-logging branch from 3ee61a7 to 30f58ba Compare January 31, 2025 23:55
@jonathan-innis jonathan-innis force-pushed the add-more-scheduler-logging branch from 30f58ba to c0e2a6d Compare January 31, 2025 23:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13082747330

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 81.211%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/provisioning/scheduling/scheduler.go 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 94.81%
Totals Coverage Status
Change from base Build 13082187201: -0.02%
Covered Lines: 9090
Relevant Lines: 11193

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants