Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Don't DeepCopy DaemonSet Pods #1968

Merged
merged 1 commit into from
Feb 6, 2025
Merged

perf: Don't DeepCopy DaemonSet Pods #1968

merged 1 commit into from
Feb 6, 2025

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

When hydrating DaemonSet pod data to handle resource quotas and mutating webhooks, we can reduce the number of pods that we list by using the same labelSelector that the DaemonSet does to perform the list against the cache

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2025
@jonathan-innis jonathan-innis force-pushed the only-select-ds-pods branch 2 times, most recently from 690b60f to 91135fc Compare February 5, 2025 23:38
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2025
@jonathan-innis jonathan-innis force-pushed the only-select-ds-pods branch 2 times, most recently from 00642cd to b506e21 Compare February 6, 2025 00:16
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2025
@coveralls
Copy link

coveralls commented Feb 6, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13170427327

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 81.296%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 94.42%
pkg/controllers/disruption/consolidation.go 4 88.55%
Totals Coverage Status
Change from base Build 13168780395: -0.03%
Covered Lines: 9149
Relevant Lines: 11254
💛 - Coveralls

@jonathan-innis jonathan-innis changed the title perf: Only select DaemonSet pods that match DaemonSet labels perf: Don't DeepCopy DaemonSet Pods Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2025
@jonathan-innis jonathan-innis force-pushed the only-select-ds-pods branch 2 times, most recently from fee8c5b to e8b53a7 Compare February 6, 2025 18:20
rschalo
rschalo approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, rschalo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 204531a into kubernetes-sigs:main Feb 6, 2025
13 checks passed
@jonathan-innis jonathan-innis mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschalo rschalo rschalo approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@rschalo rschalo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathan-innis @coveralls @k8s-ci-robot @rschalo