-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: A missing Helm parameter storageClass.create
in README.md
#353
base: master
Are you sure you want to change the base?
Conversation
Welcome @matoruru! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@humblec @jackielii How about this change? |
LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackielii, matoruru, thyarles The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This parameter is existing in the template and values.yaml, but not mentioned in the README.
nfs-subdir-external-provisioner/charts/nfs-subdir-external-provisioner/templates/storageclass.yaml
Lines 1 to 3 in 59a3ca2
nfs-subdir-external-provisioner/charts/nfs-subdir-external-provisioner/values.yaml
Lines 19 to 20 in 59a3ca2