Skip to content

Commit

Permalink
Merge pull request #8229 from kannon92/deprecate-node-feature
Browse files Browse the repository at this point in the history
drop mention of NodeFeature
  • Loading branch information
k8s-ci-robot authored Jan 15, 2025
2 parents ac80043 + 6050d74 commit 5634480
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions contributors/devel/sig-node/e2e-node-tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,10 @@ Image configuration files can further influence how FOCUS and SKIP match test ca
For example:
```sh
--focus="\[NodeFeature:.+\]" --skip="\[Flaky\]|\[Serial\]"
--focus="\[Feature:.+\]" --skip="\[Flaky\]|\[Serial\]"
```
runs all e2e tests labeled `"[NodeFeature:*]"` and will skip any tests labeled `"[Flaky]"` or `"[Serial]"`.
runs all e2e tests labeled `"[Feature:*]"` and will skip any tests labeled `"[Flaky]"` or `"[Serial]"`.
Two example e2e tests that match this expression are:
* https://github.com/kubernetes/kubernetes/blob/0e2220b4462130ae8a22ed657e8979f7844e22c1/test/e2e_node/security_context_test.go#L155
Expand Down Expand Up @@ -235,15 +235,15 @@ To run a particular e2e test, simply pass the Grinkgo `It` string to the `--focu
For example, suppose we have the following test case: https://github.com/kubernetes/kubernetes/blob/0e2220b4462130ae8a22ed657e8979f7844e22c1/test/e2e_node/security_context_test.go#L175. We could select this test case by adding the argument:
```sh
--focus="should not show its pid in the non-hostpid containers \[NodeFeature:HostAccess\]"
--focus="should not show its pid in the non-hostpid containers \[Feature:HostAccess\]"
```
## Run all tests related to a feature
In contrast, to run all node e2e tests related to the "HostAccess" feature one could run:
```sh
--focus="\[NodeFeature:HostAccess\]"
--focus="\[Feature:HostAccess\]"
```
## Run tests continually until they fail
Expand Down

0 comments on commit 5634480

Please sign in to comment.