cleanup: Remove scripts that are no longer needed #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
the
dco-signoff: yes
|
/test check-provision-k8s-1.31 |
brianmcarey
force-pushed
the
cleanup-old-scripts
branch
from
2037356 to
c3d8ee1
Compare
These scripts are no longer required since the logic has been moved into gocli[1] Remove them to avoid causing confusion for people. [1] kubevirt#1217 Signed-off-by: Brian Carey <[email protected]>
brianmcarey
force-pushed
the
cleanup-old-scripts
branch
from
c3d8ee1 to
2dd38a6
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
dosubot
bot
added
the
kind/cleanup
|
/cc @aerosouund |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
kubevirt-bot
added a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Oct 24, 2024
[25df27b cleanup: Remove scripts that are no longer needed](kubevirt/kubevirtci#1304) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot
added a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Oct 25, 2024
[a22c0ae Run bazelisk run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-last-three-minor-of v1 --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s](kubevirt/kubevirtci#1311) [c13fce6 bind-vfio: Remove "Error" from echo statement to reduce noise in prow job logs](kubevirt/kubevirtci#1312) [25df27b cleanup: Remove scripts that are no longer needed](kubevirt/kubevirtci#1304) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
These scripts are no longer required since the logic has been moved into
gocli[1]
Remove them to avoid causing confusion for people.
[1] #1217
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: