make malachite server port configurable #584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc @WangZzzhe @caohe |
cccaoke
force-pushed
the
make-malachite-port-configurable
branch
2 times, most recently
from
667b0a3 to
16cc4a2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
+ Coverage 56.14% 56.18% +0.03%
==========================================
Files 535 535
Lines 49865 49874 +9
==========================================
+ Hits 27997 28022 +25
+ Misses 18307 18283 -24
- Partials 3561 3569 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
caohe
added
enhancement
cccaoke
force-pushed
the
make-malachite-port-configurable
branch
from
16cc4a2 to
0341ba1
Compare
|
the conflict has been resolved，pls take a look @waynepeking348 @nightmeng |
cccaoke
force-pushed
the
make-malachite-port-configurable
branch
from
0341ba1 to
124c5b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
malachite metrics provisoner using default port(9002) that may be used by others, by overriding the Rocket config file, but not katalyst.
Which issue(s) this PR fixes:
make malachite server port configurable
Special notes for your reviewer: