feat: add MaxNodeUtilizationPercent in ReclaimedResourceConfiguration #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangZzzhe
requested review from
nightmeng,
csfldf and
waynepeking348
as code owners
WangZzzhe
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
==========================================
- Coverage 57.18% 57.03% -0.16%
==========================================
Files 558 566 +8
Lines 54146 54508 +362
==========================================
+ Hits 30966 31087 +121
- Misses 19305 19510 +205
- Partials 3875 3911 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
WangZzzhe
force-pushed
the
dev/node-utilization-percent
branch
from
a666b97 to
9f2e149
Compare
WangZzzhe
force-pushed
the
dev/node-utilization-percent
branch
from
9f2e149 to
dbc797f
Compare
luomingmeng
reviewed
Aug 29, 2024
| } | ||
|
|
||
| c.CPUHeadroomConfiguration.ApplyConfiguration(conf) | ||
| c.MemoryHeadroomConfiguration.ApplyConfiguration(conf) | ||
| } | ||
|
|
||
| func (c *ReclaimedResourceConfiguration) GetReservedResourceForAllocate(nodeResourceList v1.ResourceList) v1.ResourceList { |
There was a problem hiding this comment.
It may be better for GetReservedResourceForAllocate to use resource name and quantity as two separate input parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Add parameter MaxNodeUtilizationPercent，which will be converted to reservedForAllocated to limit the total amount of reclaimed resources.
PR should be updated after kubewharf/katalyst-api#85 is merged