Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allocate dedicated without exclusive and reclaim on a numa node #618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WangZzzhe
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

support allocate dedicated without exclusive and reclaim on a numa node

  1. cpu advisor estimate dedicated pod with numaBinding without exclusive by pod requests.
    And allocate cpus which are not bind to dedicated pods to reclaim pool
  2. cpu server always generate new blocks for dedicated pod with numaBinding without exclusive
  3. cpu dynamic plugin reuse cpus for dedicated pods without exclusive to make sure these pods always bind with static cpus.

@WangZzzhe WangZzzhe added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jun 11, 2024
@WangZzzhe WangZzzhe self-assigned this Jun 11, 2024
@WangZzzhe WangZzzhe force-pushed the dev/dedicated-without-exclusive-reclaim branch from b091c4b to 8f4600f Compare June 11, 2024 04:05
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 82.17054% with 23 lines in your changes missing coverage. Please review.

Project coverage is 56.33%. Comparing base (5e1814b) to head (8f4600f).
Report is 10 commits behind head on main.

Files Patch % Lines
...sor/plugin/qosaware/resource/cpu/advisor_helper.go 59.09% 6 Missing and 3 partials ⚠️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 66.66% 5 Missing and 3 partials ⚠️
...urce/cpu/region/region_dedicated_numa_exclusive.go 82.75% 3 Missing and 2 partials ⚠️
...nt/sysadvisor/plugin/qosaware/server/cpu_server.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   56.14%   56.33%   +0.19%     
==========================================
  Files         535      543       +8     
  Lines       49865    50473     +608     
==========================================
+ Hits        27997    28436     +439     
- Misses      18307    18452     +145     
- Partials     3561     3585      +24     
Flag Coverage Δ
unittest 56.33% <82.17%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WangZzzhe
Copy link
Collaborator Author

regionDedicatedNUMAExclusive -> regionDedicatedNUMA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant