Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tmo): modify calculation algorithm #700

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tmo): modify calculation algorithm #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions pkg/agent/sysadvisor/plugin/qosaware/resource/memory/plugin/memory_offloading.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,13 @@ const (
)

const (
InactiveProbe = 0.1
OffloadingSizeScaleCoeff = 1.05
CacheMappedCoeff = 2
InactiveProbe = 0.1
OffloadingSizeScaleCoeff = 1.2
CacheMappedCoeff = 2
AttenuationCoeff = 0.5
MinReclaimSize = 256 << 10 // 256 KiB
ReclaimRampUpStep = 256 << 10 // 256 KiB
IndependentRefaultThreshold = 1000
)

const (
Expand Down Expand Up @@ -118,16 +122,19 @@ func refaultPolicyFunc(lastStats TmoStats, currStats TmoStats, conf *tmoconf.TMO
if pgstealDelta > 0 && pgscanDelta > 0 {
reclaimAccuracyRatio = 1 - refaultDelta/pgstealDelta
reclaimScanEfficiencyRatio = pgstealDelta / pgscanDelta
} else if refaultDelta > IndependentRefaultThreshold {
reclaimAccuracyRatio = 0
}

var result float64
if reclaimAccuracyRatio < conf.RefaultPolicyConf.ReclaimAccuracyTarget || reclaimScanEfficiencyRatio < conf.RefaultPolicyConf.ReclaimScanEfficiencyTarget {
// Decrease offloading size if detecting the reclaim accuracy or scan efficiency is below the targets
result = math.Max(0, lastStats.offloadingTargetSize*reclaimAccuracyRatio)
result = math.Max(AttenuationCoeff, reclaimAccuracyRatio) * lastStats.offloadingTargetSize
} else {
// Try to increase offloading size but make sure not exceed the max probe of memory usage and 10% of inactive memory when the target size of last round is relatively small,
// which means reclaim accuracy and reclaim scan efficiency is low.
result = math.Min(math.Max(lastStats.offloadingTargetSize*OffloadingSizeScaleCoeff, currStats.memInactive*InactiveProbe), currStats.memUsage*conf.RefaultPolicyConf.MaxProbe)
tmp := math.Min(lastStats.offloadingTargetSize*OffloadingSizeScaleCoeff, lastStats.offloadingTargetSize+ReclaimRampUpStep)
result = math.Min(math.Max(tmp, MinReclaimSize), math.Min(currStats.memInactive*InactiveProbe, currStats.memUsage*conf.RefaultPolicyConf.MaxProbe))
}
general.InfoS("refault info", "obj", currStats.obj, "reclaimAccuracyRatio", reclaimAccuracyRatio, "ReclaimAccuracyTarget", conf.RefaultPolicyConf.ReclaimAccuracyTarget,
"reclaimScanEfficiencyRatio", reclaimScanEfficiencyRatio, "ReclaimScanEfficiencyTarget", conf.RefaultPolicyConf.ReclaimScanEfficiencyTarget,
Expand Down
Loading