Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRM cpu plugin support hint optimizer #746

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

luomingmeng
Copy link
Collaborator

@luomingmeng luomingmeng commented Dec 18, 2024

What type of PR is this?

Enhancements

What this PR does / why we need it:

It introduces a hint optimizer feature for the QRM CPU plugin. The addition aims to enhance the efficiency and accuracy of resource allocation.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng force-pushed the dev/qrm-support-hint-optimizer branch 4 times, most recently from 0bd85ed to d860b40 Compare December 18, 2024 06:58
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 60.89552% with 131 lines in your changes missing coverage. Please review.

Project coverage is 56.91%. Comparing base (8286a73) to head (26e5f7c).

Files with missing lines Patch % Lines
...icpolicy/hintoptimizer/serviceprofile/optimizer.go 62.64% 70 Missing and 26 partials ⚠️
pkg/metaserver/spd/util.go 55.00% 5 Missing and 4 partials ⚠️
pkg/util/native/resources.go 65.00% 5 Missing and 2 partials ⚠️
cmd/katalyst-agent/app/options/qrm/cpu_plugin.go 69.23% 4 Missing ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 0.00% 4 Missing ⚠️
...sadvisor/plugin/qosaware/resource/helper/helper.go 0.00% 1 Missing and 3 partials ⚠️
pkg/metaserver/spd/manager.go 55.55% 2 Missing and 2 partials ⚠️
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   56.84%   56.91%   +0.07%     
==========================================
  Files         601      603       +2     
  Lines       69809    70120     +311     
==========================================
+ Hits        39680    39910     +230     
- Misses      25864    25915      +51     
- Partials     4265     4295      +30     
Flag Coverage Δ
unittest 56.91% <60.89%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/qrm-support-hint-optimizer branch 14 times, most recently from b5c430d to 26e5f7c Compare December 20, 2024 11:38
@luomingmeng luomingmeng force-pushed the dev/qrm-support-hint-optimizer branch from 26e5f7c to 2fb2e50 Compare January 16, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant