Add gnu-stack notes

In binutils-2.39, GNU ld has added a warning when linking objects that don't have a .note.GNU-stack section. Since we build with "--fatal-warnings", this causes a failure: ld: warning: cert.o: missing .note.GNU-stack section implies executable stack ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker This patch adds those sections to all of the .S files, so that they will be in the objects, as well as updating our gnu-efi tree the same way. Signed-off-by: Peter Jones <[email protected]>
kukrimate · Jun 23, 2023 · 118ff87 · 118ff87
1 parent 89d25a1
commit 118ff87
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/cert.S b/cert.S
@@ -52,3 +52,4 @@ vendor_deauthorized:
 #endif
 .Lvendor_deauthorized_end:
 .Lcert_table_end:
+	.section .note.GNU-stack,"a"
diff --git a/gnu-efi b/gnu-efi
diff --git a/sbat_var.S b/sbat_var.S
@@ -20,3 +20,4 @@ sbat_var_payload_header:
 .Lsbat_var_latest:
 	.ascii SBAT_VAR_LATEST
 	.byte 0
+	.section .note.GNU-stack,"a"
+1 −1		Make.defaults
+1 −0		apps/trivial.S
+1 −0		gnuefi/crt0-efi-aarch64.S
+1 −0		gnuefi/crt0-efi-arm.S
+1 −0		gnuefi/crt0-efi-ia32.S
+1 −0		gnuefi/crt0-efi-ia64.S
+1 −0		gnuefi/crt0-efi-mips64el.S
+1 −0		gnuefi/crt0-efi-x86_64.S
+1 −0		gnuefi/reloc_ia64.S
+1 −0		lib/aarch64/efi_stub.S
+1 −0		lib/aarch64/setjmp.S
+1 −0		lib/arm/div.S
+1 −0		lib/arm/efi_stub.S
+1 −0		lib/arm/ldivmod.S
+1 −0		lib/arm/llsl.S
+1 −0		lib/arm/llsr.S
+1 −0		lib/arm/mullu.S
+1 −0		lib/arm/setjmp.S
+1 −0		lib/arm/uldiv.S
+1 −0		lib/ia32/efi_stub.S
+1 −0		lib/ia32/setjmp.S
+1 −0		lib/ia64/palproc.S
+1 −0		lib/ia64/setjmp.S
+1 −0		lib/mips64el/efi_stub.S
+1 −0		lib/mips64el/setjmp.S
+1 −0		lib/x86_64/efi_stub.S
+1 −0		lib/x86_64/setjmp.S