Add Support for axum::extract::Path #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test does use axum Query not Path
This turns a axum::extract::Path into a parameter
|
Thank you for submitting this and including the test case. Made it incredibly easy to help you out. The Parameter schema doesn't have the route information, so this logic can't be in the macro, but it's pretty straight forward to put the logic in the route registration function. I updated the logic, pushed to the PR. Let me know if there's anything else you were aiming to include in the PR. Otherwise happy to merge and cut a patch release. |
|
@kurtbuilds Thanks for fixing this. I will probably come back with some more features, mainly around Autnentication but for now this PR is ready from my side. |
|
Sounds great. Cut and published as 0.20.1. Happy to chat about auth when you dive deeper on that front. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support to add parameters passed via
axum::extract::Pathto the parameters section.It's currently draft because I couldn't figure out how I could get the path parameter name to set the
namevalue. And thus the test is currently failing.@kurtbuilds Any idea how this could be achieved?