Skip to content

Commit

Permalink
Bug Fix: Add Indonesian and Malaysian Currency Transformer (Reopen) (#…
Browse files Browse the repository at this point in the history
…184)

* Update ManagesCurrencyTransformers.php

Add Indonesian Currency Transformer

* Update ManagesCurrencyTransformers.php

Add Malaysian Currency Transformer

* Update EnglishDictionary.php

Add Indonesian Rupiah and Malaysian Ringgit to EnglishDictionary.php

* Add Indonesian Rupiah and Malaysian Ringgit Unit Test

* Fix the mistaken unit test

* Fix first letter capital in Rupiah IDR and Ringgit MYR
  • Loading branch information
ayrus02 authored Jan 7, 2025
1 parent 64a3243 commit c1fede5
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/Concerns/ManagesCurrencyTransformers.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ trait ManagesCurrencyTransformers
'es' => Transformer\SpanishCurrencyTransformer::class,
'fr' => Transformer\FrenchCurrencyTransformer::class,
'hu' => Transformer\HungarianCurrencyTransformer::class,
'id' => Transformer\IndonesianCurrencyTransformer::class,
'ka' => Transformer\GeorgianCurrencyTransformer::class,
'lt' => Transformer\LithuanianCurrencyTransformer::class,
'lv' => Transformer\LatvianCurrencyTransformer::class,
'ms' => Transformer\MalaysianCurrencyTransformer::class,
'pl' => Transformer\PolishCurrencyTransformer::class,
'pt_BR' => Transformer\PortugueseBrazilianCurrencyTransformer::class,
'ro' => Transformer\RomanianCurrencyTransformer::class,
Expand Down
2 changes: 2 additions & 0 deletions src/Language/English/EnglishDictionary.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class EnglishDictionary implements Dictionary
'HKD' => [['Hong Kong dollar'], ['cent']],
'HRK' => [['Croatian kuna'], ['lipa']],
'HUF' => [['forint'], ['filler']],
'IDR' => [['rupiah'], ['sen']],
'ILS' => [['new sheqel', 'new sheqels'], ['agora', 'agorot']],
'ISK' => [['Icelandic króna'], ['aurar']],
'JPY' => [['yen'], ['sen']],
Expand All @@ -71,6 +72,7 @@ class EnglishDictionary implements Dictionary
'MKD' => [['Macedonian dinar'], ['deni']],
'MRO' => [['ouguiya'], ['khoums']],
'MTL' => [['Maltese lira'], ['centym']],
'MYR' => [['ringgit'], ['sen']],
'NGN' => [['Naira'], ['kobo']],
'NOK' => [['Norwegian krone'], ['oere']],
'PHP' => [['peso'], ['centavo']],
Expand Down
10 changes: 10 additions & 0 deletions tests/CurrencyTransformer/EnglishCurrencyTransformerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,16 @@ public function providerItConvertsMoneyAmountToWords(): array
[-72925, 'USD', 'minus seven hundred twenty-nine dollars twenty-five cents'],
[-89425, 'USD', 'minus eight hundred ninety-four dollars twenty-five cents'],
[-99925, 'USD', 'minus nine hundred ninety-nine dollars twenty-five cents'],
[70800000, 'IDR', 'seven hundred eight thousand rupiahs'],
[276037213, 'IDR', 'two million seven hundred sixty thousand three hundred seventy-two rupiahs thirteen sens'],
[857998800, 'IDR', 'eight million five hundred seventy-nine thousand nine hundred eighty-eight rupiahs'],
[2227500000, 'IDR', 'twenty-two million two hundred seventy-five thousand rupiahs'],
[-191418500, 'IDR', 'minus one million nine hundred fourteen thousand one hundred eighty-five rupiahs'],
[7200000, 'MYR', 'seventy-two thousand ringgits'],
[177537065, 'MYR', 'one million seven hundred seventy-five thousand three hundred seventy ringgits sixty-five sens'],
[247314700, 'MYR', 'two million four hundred seventy-three thousand one hundred forty-seven ringgits'],
[980000000, 'MYR', 'nine million eight hundred thousand ringgits'],
[-135522300, 'MYR', 'minus one million three hundred fifty-five thousand two hundred twenty-three ringgits'],
];
}
}

0 comments on commit c1fede5

Please sign in to comment.