refactor(lint): changes to fix lint and suppress dupl lint

cmd/root.go

@@ -106,23 +106,23 @@ func initConfig() {
 /* Private Helpers */
 
 func parseValidateInputs(args []string) error {
-	var ok bool = false
-	var err error = nil
-
 	// validate pvr exists in config
 	pvrName = args[0]
 	lowerPvrName = strings.ToLower(pvrName)
-	pvrConfig, ok = config.Config.Pvr[pvrName]
+	pc, ok := config.Config.Pvr[pvrName]
 	if !ok {
 		return fmt.Errorf("no pvr configuration found for: %q", pvrName)
 	}
 
+	pvrConfig = pc
+
 	// init pvrObj
-	pvr, err = pvrObj.Get(pvrName, pvrConfig.Type, pvrConfig)
+	p, err := pvrObj.Get(pvrName, pvrConfig.Type, pvrConfig)
 	if err != nil {
 		return errors.WithMessage(err, "failed loading pvr object")
 	}
 
+	pvr = p
 	return nil
 }
 
@@ -148,7 +148,7 @@ func searchForItems(searchItems []pvrObj.MediaItem, wantedType string) (bool, er
 		return false, errors.New("failed unexpectedly searching for items")
 	} else {
 		// update search items lastsearch time
-		for pos, _ := range searchItems {
+		for pos := range searchItems {
 			(&searchItems[pos]).LastSearch = searchTime
 		}
 

database/delete.go

@@ -7,7 +7,7 @@ import (
 
 func DeleteMissingItems(pvrName string, wantedType string, newMediaItems []pvr.MediaItem) (int, error) {
 	// build slice of new item ids
-	newItemIds := make(map[int]*string, 0)
+	newItemIds := make(map[int]*string)
 
 	for _, item := range newMediaItems {
 		newItemIds[item.ItemId] = nil
@@ -29,6 +29,8 @@ func DeleteMissingItems(pvrName string, wantedType string, newMediaItems []pvr.M
 
 	for _, item := range dbItems {
 		if _, ok := newItemIds[item.Id]; !ok {
+			item := item
+
 			// item no longer exists
 			if err := tx.Unscoped().Delete(&item).Error; err != nil {
 				tx.Rollback()