Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools_scm: support reading version from archive #1557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alextercete
Copy link

@alextercete alextercete commented Dec 10, 2024

Description
Currently, it's not possible to pip install the labgrid package by using the GitHub archive URL. However, setuptools_scm supports this with a few files added to the repo.

Testing
This fails:

pip install https://github.com/labgrid-project/labgrid/zipball/master

This succeeds:

pip install https://github.com/arm-software/labgrid/zipball/pip-install-from-archive

Checklist

  • Documentation for the feature: N/A
  • Tests for the feature: N/A
  • PR has been tested

.git_archival.txt Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.2%. Comparing base (d98677c) to head (d19d2cf).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1557   +/-   ##
======================================
  Coverage    56.1%   56.2%           
======================================
  Files         170     170           
  Lines       13225   13247   +22     
======================================
+ Hits         7432    7449   +17     
- Misses       5793    5798    +5     
Flag Coverage Δ
3.10 56.2% <ø> (+<0.1%) ⬆️
3.11 56.2% <ø> (+<0.1%) ⬆️
3.12 56.2% <ø> (+<0.1%) ⬆️
3.13 56.1% <ø> (+<0.1%) ⬆️
3.9 56.2% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Currently, it's not possible to `pip install` the `labgrid` package by
using the GitHub archive URL. However, `setuptools_scm` supports
this[1] with a few files added to the repo.

[1]: https://setuptools-scm.readthedocs.io/en/latest/usage/#git-archives

Signed-off-by: Alex Tercete <[email protected]>
@alextercete alextercete force-pushed the pip-install-from-archive branch from f1eb734 to d19d2cf Compare January 7, 2025 09:54
@alextercete alextercete removed their assignment Jan 7, 2025
@alextercete alextercete requested a review from Emantor January 7, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants