Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPENDS_ON arrows and text bold #930

Merged
merged 4 commits into from
Sep 24, 2024
Merged

DEPENDS_ON arrows and text bold #930

merged 4 commits into from
Sep 24, 2024

Conversation

Leahh02
Copy link
Collaborator

@Leahh02 Leahh02 commented Sep 20, 2024

Made the depends on arrows and text bold to address part of Issue 921. I also realized that when I set the output label to "value" the cat-grep-tar dag was messed up, so I set the label back to "glob". I ran the generate_graph.py file on my personal laptop, so I also want to try running it on Darwin to make sure it's still fine.

@Leahh02 Leahh02 added WIP (no-ci) Don't run any CI for this PR and removed WIP (no-ci) Don't run any CI for this PR labels Sep 20, 2024
@Leahh02 Leahh02 added enhancement New feature or request and removed WIP (no-ci) Don't run any CI for this PR labels Sep 23, 2024
@Leahh02 Leahh02 requested a review from pagrubel September 23, 2024 14:24
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leah, can you make the line a little thicker?

Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leahh02 In addition to making the lines a little thicker for DEPENDS_ON, could you add RESTARTED_FROM.

Here is an example of a checkpointed workflow.
fd-complete

Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leahh02 Just noticed this output from beeflow dag --help:


   Usage: beeflow dag [OPTIONS] WF_ID

  Export a DAG of the workflow to a GraphML file.

should it be png image file

Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Leah this look great!
The help verbage will be addressed in the other dag PR

@pagrubel pagrubel merged commit cd51dc2 into develop Sep 24, 2024
6 checks passed
@pagrubel pagrubel deleted the Issue921/Dag-apperance branch September 24, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants