Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAG Paths #931

Merged
merged 25 commits into from
Oct 7, 2024
Merged

DAG Paths #931

merged 25 commits into from
Oct 7, 2024

Conversation

Leahh02
Copy link
Collaborator

@Leahh02 Leahh02 commented Sep 20, 2024

I made multiple versions of the DAGs without overriding old versions. I also added an argument to specify where to save the DAGs to. I updated the documentation for this. I wrote this on my personal computer and still need to test it on Darwin.

@Leahh02 Leahh02 added the WIP (no-ci) Don't run any CI for this PR label Sep 20, 2024
@Leahh02
Copy link
Collaborator Author

Leahh02 commented Sep 23, 2024

The DAGs are being saved in a DAG directory within the directory they specify right now. So running beeflow dag $SHORT_ID $WORKDIR will save the Dags in a directory $SHORT_ID_dags and that directory is in the $WORKDIR.

If someone doesn't want to make the dags directory they can use the --no-dag-dir and the dags will just be saved in the directory they specify.

You can now make multiple versions of the DAGs. The current one is $SHORT_ID.png, and then the other ones are $SHORT_ID_v1.png, $SHORT_ID_v2.png ... where v1 is the oldest

I'm saving the final dag to the workflow directory which then gets saved to the archive directory.

I updated documentation for these changes.

I haven't changed how things are named yet, which was something in issue 921 and is similar to these changes.

@Leahh02 Leahh02 removed the WIP (no-ci) Don't run any CI for this PR label Sep 23, 2024
@Leahh02
Copy link
Collaborator Author

Leahh02 commented Sep 24, 2024

I can change the names of the dags directory and the actual dags themselves to whatever people think is best. I.e. I can change the $SHORT_ID_dags directory and the $SHORT_ID_dags

@pagrubel
Copy link
Collaborator

pagrubel commented Sep 27, 2024

You can now make multiple versions of the DAGs. The current one is $SHORT_ID.png, and then the other ones are $SHORT_ID_v1.png, $SHORT_ID_v2.png ... where v1 is the oldest

@Leahh02 I like your explanation here and think something like it should be added to the documentation for clarification such as:

"The most recent version is $SHORT_ID.png and the others are $SHORT_ID_v1.png, $SHORT_ID_v2.png ... where v1 is the oldest."

@pagrubel
Copy link
Collaborator

@Leahh02 Would it be useful to have the graphmls in the workflow archive? You mentioned earlier they might be useful for debugging.

This looks very good and flexible for the user. If you can fix the tests and make the small documentation change I think we should merge this.

@Leahh02 Leahh02 added the WIP (no-ci) Don't run any CI for this PR label Sep 30, 2024
@Leahh02 Leahh02 removed the WIP (no-ci) Don't run any CI for this PR label Sep 30, 2024
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I added a comment to the main issue about having a Dockerfile for the neo4j container, so it can be updated in one place. This can be done when the beeflow core pull-deps is fixed though.

@pagrubel pagrubel merged commit b48c061 into develop Oct 7, 2024
6 checks passed
@pagrubel pagrubel deleted the Issue921/Dag-paths branch January 8, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants