Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue883/add check for different front end #933

Merged
merged 19 commits into from
Nov 5, 2024

Conversation

kchilleri
Copy link
Collaborator

This PR adds a database to the client to keep track of the name of the front end where beeflow is started. Every time a beeflow core * command is submitted, we check if the current front end is the same as the one where beeflow was started from. If not, it returns a warning and exits.

@kchilleri kchilleri linked an issue Oct 1, 2024 that may be closed by this pull request
@kchilleri kchilleri added the WIP (no-ci) Don't run any CI for this PR label Oct 1, 2024
@kchilleri kchilleri added WIP Work in progress and removed WIP (no-ci) Don't run any CI for this PR labels Oct 1, 2024
@kchilleri
Copy link
Collaborator Author

To Do:

  1. Add more error checking.
  2. Add testing (I have a test for the database but need a separate one for the rest of the code).

@kchilleri kchilleri requested a review from rstyd October 1, 2024 20:51
@kchilleri kchilleri removed the WIP Work in progress label Oct 1, 2024
beeflow/client/bee_client.py Outdated Show resolved Hide resolved
@kchilleri kchilleri requested a review from rstyd October 14, 2024 23:01
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to do a "beeflow core start" on a front end different than one that had beeflow running on it. I don't see a check for this in beeflow start command in core.py

Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is only a check for the commands beeflow core status and stop
There should also be checks for start , restart, and reset.

It isn't needed for pull-deps or info though

@kchilleri
Copy link
Collaborator Author

kchilleri commented Nov 1, 2024

@pagrubel I am not adding checks to restart and reset commands because they call the stop function which already contains the check, but I will add one to the start command

@pagrubel
Copy link
Collaborator

pagrubel commented Nov 1, 2024

@pagrubel I am not adding checks to restart and reset commands because they call the stop function which already contains the check, but I will add one to the start command

That makes sense for restart but reset does quite a bit of checking before it does the stop so I think a check there might be warranted

@kchilleri kchilleri requested a review from pagrubel November 4, 2024 16:50
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for reset and start now.

@pagrubel pagrubel merged commit 0e27361 into develop Nov 5, 2024
6 checks passed
@pagrubel pagrubel deleted the issue883/add-check-for-different-front-end branch November 5, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Check for Different Front End
3 participants