Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random pass for neo4j #948

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Use random pass for neo4j #948

merged 3 commits into from
Nov 12, 2024

Conversation

aquan9
Copy link
Collaborator

@aquan9 aquan9 commented Oct 15, 2024

This PR changes the way that we initialize the default password for the neo4j database to be based on a random base64 hash value rather than just the default "password" text, which should hopefully make our database more secure on shared systems.

The concern is that since the graph database is setup on the shared front-end, automatically setting up a default password of "password" would let other users explore things like the names of steps in another user's workflow, and how their workflow is setup.

@aquan9
Copy link
Collaborator Author

aquan9 commented Oct 15, 2024

This PR resolves issue #772

@aquan9 aquan9 requested a review from rstyd October 18, 2024 05:50
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @aquan9. I merged develop and fixed conflicts caused by a different change to configuration.

@pagrubel pagrubel merged commit d0e68fb into develop Nov 12, 2024
6 checks passed
@pagrubel pagrubel deleted the neo4j-password branch November 12, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants