Issue877/Add config option for archive directory #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhall0
added
enhancement
pagrubel
reviewed
Dec 4, 2024
|
Now that you mention it, it doesn't look like we currently have anything in the documentation that breaks down the individual configuration options, and I can't find a good place to include this info in the documentation as currently written. I propose we create a separate issue to add a page to the docs that breaks down all the config options and it'll include this as well. |
|
Sounds good |
|
This looks great! The only change I would recommend is to add a line to ci/bee_config.sh so that it's using your new config option. I'm also putting up an issue for changing this script so it's not hard coded since it's a pain to maintain. |
pagrubel
deleted the
877-add-configuration-option-to-specify-the-archive-directory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #877
This PR adds a config option to change the directory where workflows are archived. By default this is set to the same location that was used previously (
~/.beeflow/archives). If you manually adjust thebee.confoptionbee_archive_dirto any other folder; it will be used instead. As with the default, the folder does not need to already exist.I tested this using the
cat-grep-tarexample ensuring the default behavior worked as expected. I then setbee_archive_dir = $HOMEDIR/BEE_jobs/archiveswith $HOMEDIR filled in as appropriate; and ensured the archived was placed in the new folder.I ensured tests passed using: