Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added yaml workflow files for testing installation of Fierro via anaconda and some example input, for the purpose of CI #207

Merged
merged 75 commits into from
Jul 24, 2024

Conversation

zacharyjbaker
Copy link
Collaborator

@zacharyjbaker zacharyjbaker commented Jul 9, 2024

Description

ENH: Added yaml workflow files for testing installation of Fierro via anaconda and some example input, for the purpose of CI

Fierro Test triggers whenever a publishing workflow is run. No reversion functionality, for now we decided to do reversions manually through Client CLI in the case of a failed test.

Publish All workflow currently not functional as workflow_call: must be added to each publish yaml file, but I don't want to create 10 pull requests to do that.

Type of change

Please select all relevant options

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Formatting and/or style fixes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A : The workflows trigger on a push to main, and should successfully run the parallel-explicit, mesh, and parallel-implicit commands with the listed example inputs (implicit takes a very long time)
  • Test B :

Test Configuration:

  • OS version:
  • Hardware:
  • Compiler:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code builds from scratch with my new changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@djdunning djdunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end. Do we know why the implicit solver takes so much longer? I didn't think it should, maybe it was just a testing anomaly.

@Adrian-Diaz
Copy link
Collaborator

Looks good on my end. Do we know why the implicit solver takes so much longer? I didn't think it should, maybe it was just a testing anomaly.

Its performing an optimization run with that yaml file

@nathanielmorgan
Copy link
Collaborator

Lets make this CI workflow run when we deploy a new conda distributions

@jacob-moore22
Copy link
Collaborator

This is great. The only tweak is to change it to test only after publishing the Conda packages instead of on each push.

@Adrian-Diaz
Copy link
Collaborator

Ideally it would build a separate version and test but not publish. We should just manually tell it to publish when it's safe to do so.

Copy link
Collaborator

@nathanielmorgan nathanielmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Having CI of anaconda is great.

@nathanielmorgan nathanielmorgan merged commit fe0ecde into lanl:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants