Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core logger #122

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Core logger #122

merged 11 commits into from
Oct 31, 2024

Conversation

Vedant1
Copy link
Collaborator

@Vedant1 Vedant1 commented Oct 31, 2024

  • created a logger in core to track runtime for each plugin/backend - only writes to a txt file if debug flag on

  • updated dsi capablities to work on python 3.11 and up only

  • updated toml reader to use inbuilt tomllib library in python 3.11 instead of manual parsing toml files

  • get_artifact in sqlite backend returns dictionary of results from query

  • renamed back-end and front-end to back-writer and back-reader to make it clearer for a user

@jpulidojr jpulidojr self-requested a review October 31, 2024 22:58
Copy link
Collaborator

@jpulidojr jpulidojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed tests. Commented out direct back-end calls to toml and yaml readers which are now properly implemented as plugins going through abstraction layer.

@jpulidojr jpulidojr merged commit 3a9857a into main Oct 31, 2024
4 checks passed
@jpulidojr jpulidojr deleted the core_logger branch October 31, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants