Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units tests changes #134

Merged
merged 34 commits into from
Jan 21, 2025
Merged

Units tests changes #134

merged 34 commits into from
Jan 21, 2025

Conversation

Vedant1
Copy link
Collaborator

@Vedant1 Vedant1 commented Dec 18, 2024

  • units for each table in the abstraction layer is now a dictionary instead of a list of tuples. col name is the key and unit is the value
  • error raised if an ingested column's units are different - same workflow or different
    • same workflow- error in the abstraction layer and no data is loaded into abstraction
    • different workflow - error in backend (sqlite for now) and new data not loaded
  • new CI tests for test_env.py, test_core.py and test_sqlalchemy.py
  • new plugin reader - metadata json reader (different than existing json and schema readers)
  • updated requirements.txt to just be base imports
  • new requirements.extras.txt with large package imports for full use of all DSI functions
  • updated all 6 CI files with the new requirements.extras.txt

Vedant P Iyer and others added 30 commits December 14, 2024 19:41
…e error ifmismatched units ingested for same column
@jpulidojr jpulidojr merged commit 133100b into main Jan 21, 2025
6 checks passed
@jpulidojr jpulidojr deleted the units_tests_changes branch January 21, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants