-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the documentation and examples for hyperparameter tuning #103
Conversation
Apart from some typos here and there (I'm pretty there are plenty of them is the tutorial), the PR should be ready. Sakib wrote the original sequential script and shared to me, so I think I should give him some credits. What's the best way? |
This is really cool! re: attribution, feel free to put your names in the docstring for example scripts and also, if you desire, the documentation files. e.g. "Contributed by: person (insitution), person (institution)" or something. Also, to check for my own understanding, it appears there is not a lot of reason for us to add any functions into hippynn itself, because ray/ax already operate on a fairly black-box level. As such we also don't need to add these as optional dependencies. Is that right? |
Great. I will for sure add Sakib and me, mainly for him to get the proper credits.
You are totally right. Just need some fairly small changes to the existing training scripts. We do not have to add them as the optional dependencies. |
1. Fix typos 2. Improve the warning message display 3. Add authors
@lubbersnick I have fixed some typos and add our names to the scripts and docs, but I could not push the commit due to the LANL internet issue. I will push it once the Internet is back. |
Just pushed the commit. |
@lubbersnick You have to merge it. I don't have the permission. |
@tautomer I know 🙃 |
The doc part is done, but I have not added the full example script yet.