Skip to content

Commit

Permalink
Merge pull request #398 from lanl/jhp/spack_for_release
Browse files Browse the repository at this point in the history
Update spackage in preparation for release
  • Loading branch information
Yurlungur authored Jul 26, 2024
2 parents f5e52ba + ed95ee0 commit 235b3b6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ detail. Why is this change required? What problem does it solve?-->
If preparing for a new release, in addition please check the following:
- [ ] Update the version in cmake.
- [ ] Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
- [ ] Ensure that any `when='@main'` dependencies are updated to the release version in the package.py
10 changes: 5 additions & 5 deletions spack-repo/packages/singularity-eos/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ class SingularityEos(CMakePackage, CudaPackage):
default="none",
validator=plugin_validator,
description="list of plugins to build",
when="@main"
when="@1.9.0:"
)
variant("variant", default="default", description="include path used for variant header", when="@main")
variant("variant", default="default", description="include path used for variant header", when="@1.9.0:")

# building/testing/docs
depends_on("[email protected]:")
depends_on("[email protected]:", when="@main +tests")
depends_on("[email protected]", when="@:1.8.0 +tests")
depends_on("[email protected]:", when="@1.9.0: +tests")
depends_on("python@3:", when="+python")
depends_on("py-numpy", when="+python+tests")
depends_on("[email protected]:", when="+python")
Expand All @@ -112,7 +112,7 @@ class SingularityEos(CMakePackage, CudaPackage):

depends_on("[email protected],1.5.2:", when="@:1.7.0")
depends_on("[email protected]:", when="@1.7.1:")
depends_on("[email protected]:", when="@1.8.1:")
depends_on("[email protected]:", when="@1.9.0:")
# request HEAD of main branch
depends_on("ports-of-call@main", when="@main")

Expand Down Expand Up @@ -216,7 +216,7 @@ def cmake_args(self):
self.define("SINGULARITY_USE_EOSPAC", "^eospac" in self.spec),
]

if self.spec.satisfies("@main"):
if self.spec.satisfies("@1.9.0:"):
if "none" not in self.spec.variants["plugins"].value:
pdirs = [join_path(self.stage.source_path, self.plugins[p]) for p in self.spec.variants["plugins"].value]
args.append(self.define("SINGULARITY_PLUGINS", ";".join(pdirs)))
Expand Down

0 comments on commit 235b3b6

Please sign in to comment.