-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerMG EOS implemented and documented. #336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @aematts ! Assuming tests pass, this looks good to me. I have a few minor comments, but they are suggestions, and I consider them non-blocking. Feel free to push back on them.
OK. I have fixed a few small things (initiating _M, and adding const in front of Real eta = ....) and of course forgot to rerun the formatting. |
Last comments for today:
|
Wishlist item is good. Don't worry about it for now. :)
This is an OK solution for now. We can revisit if we actually hit the limit. You could move the limit to a global const (e.g.,
This I'm not sure about and I'm curious what @jhp-lanl thinks. I worry a bit about the EOS returning things like negative bulk modulus, as a hydro code that receives something like that might go completely bonkers. I don't think this necessarily has to be solved now---it could be resolved, for example, with friendly testing from a host code, if we have people interested in using the EOS. |
In fact if you set a large negative value for Pmin (as the default) it never really kicks in but follows the isentrope all the way to infinite volume ;). |
That figure looks totally reasonable. And it's not like our tabulated EOS's don't also have crazy stuff in tension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments and suggested changes.
It's a shame the HTML can't render a PDF. I'm fine with the hyperlinks, so my suggestions are mainly to try to make it more obvious what the hyperlinks are doing and to separate them from the text.
This is ready to merge now. |
I'm running a pipeline on re-git to make sure things work there |
Pipeline passes on re-git... merging |
PR Summary
The Power Mie-Gruneisen EOS created at SNL by Robinson, adequate for high pressure modeling, is implemented and documented in relation to the linear Us-up Mie-Gruneisen implemented previously. This EOS is a full EOS with correct temperature. It is the least restrictive EOS of Mie-Gruneisen form and similar in spirit to the Extended Vinet EOS.
PR Checklist
make format
command after configuring withcmake
.