-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spackage with Plugin support #337
Conversation
e05811a
to
1c5eacf
Compare
1c5eacf
to
577194a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but @mauneyc-LANL should probably also take a look
8208662
to
f9158b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rbberger one more minor comment. Then from my perspective this is good to g. Since @mauneyc-LANL also agrees, go ahead and pull the trigger when you're ready. (Or ask me or @dholladay00 to do so.)
PR Summary
This updates the Singularity-EOS spackage to support plugins. It introduces a new directive
singularity_eos_plugin
which is used to register a plugin with a relative plugin path. While convenient, we still have to see if spack upstream would accept such a spackage change.The
plugins
variant can then choose one or more of these plugins to be used. Unknown plugin names will result in an error.variant
can be used to set the variant header location.PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following: