Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stored workflow exception id to the resource #33

Merged

Conversation

GALCF
Copy link
Contributor

@GALCF GALCF commented Oct 16, 2024

The id is used to expand / collapse exception accordions

Not returning the id resulted in html ids like 'collapseundefined', so all exceptions would expand or collapse at the same time

image

The id is used to expand / collapse exception accordions

Not returning the id resulted in html ids like 'collapseundefined', so all exceptions would expand or collapse at the same time
@rmcdaniel
Copy link
Contributor

Got some failing tests because of the new field. Can you update them or do you want me to? Thanks!

@GALCF
Copy link
Contributor Author

GALCF commented Oct 17, 2024

Got some failing tests because of the new field. Can you update them or do you want me to? Thanks!

Updated, I hope this is the right approach for this test :)

@GALCF
Copy link
Contributor Author

GALCF commented Oct 18, 2024

Got some failing tests because of the new field. Can you update them or do you want me to? Thanks!

You're free to adapt it so it works 👍

@rmcdaniel
Copy link
Contributor

Sorry for the delay. I have not forgotten about this!

@rmcdaniel rmcdaniel merged commit 2c4d04d into laravel-workflow:master Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants