Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stubs team testing - tests fails when feature disabled #1551

Conversation

ProtocolNebula
Copy link

No description provided.

@ProtocolNebula
Copy link
Author

Hi @taylorotwell , what’s the reason of closing the PR? No reason provided.

When a new project is created with the boilerplates and teams feature is disabled temporary, tests fails.

@crynobone
Copy link
Member

crynobone commented Dec 11, 2024

You can override the stubs for your application if you have these requirements. Temporarily disabling teams Is not a feature intended by Jetstream and having those conditions built-in could cause a false-negative test suite if configuration wasn't done correctly.

@ProtocolNebula
Copy link
Author

Hi @crynobone , so what about these conditionals? I cannot understand why some are valid but not others (some examples):

  • jetstream\stubs\tests\inertia\ApiTokenPermissionsTest.php
  • jetstream\stubs\tests\inertia\CreateApiTokenTest.php
  • jetstream\stubs\tests\livewire\DeleteApiTokenTest.php

On the other hand, are these valid because the developer might want the teams feature but not the invitation feature?

  • jetstream\stubs\tests\livewire\InviteTeamMemberTest.php

Based on the first block (API), they should've removed or this PR is valid, because "API" is an extra component you can not install.

Thanks in advance for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants