Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: adds application snapshot and minimizes App::make #980

Open
wants to merge 32 commits into
base: 2.x
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
5d2c26d
Replaced the 'sandbox' approach with a 'snapshot' approach.
May 13, 2024
72ad7b4
Adjusted the unit tests to reflect the new approach.
May 13, 2024
567100a
Removes some unnecessary event listeners.
May 13, 2024
addacbd
Adds more snapshot tests.
May 13, 2024
2de2e7b
Cleans up redundant code.
May 13, 2024
1af885d
Fixes style ci issues.
May 13, 2024
ad92af6
Fixes style ci issues.
May 13, 2024
8bd1193
Adds test for scoped container instances.
May 14, 2024
d2a2092
Gives event listeners access to the app snapshot.
May 14, 2024
24fc7c4
Adjusted method names.
May 14, 2024
ca23364
Fixes style ci issue.
May 14, 2024
d95ced3
Reverts deleting notification manager listener.
May 15, 2024
616bc37
Registers the listener and adds a test to ensure drivers are flushed.
May 15, 2024
fb89581
Fixes style ci.
May 15, 2024
e499184
Fixes style ci.
May 15, 2024
0290363
Fixes style ci.
May 15, 2024
8940e19
Adds a test to make sure all Application and Container properties can…
May 16, 2024
9b69cd7
Fixes style ci.
May 16, 2024
ef0a0d3
Merge branch 'refs/heads/2.x' into better_approach_to_memory_leaks_v2
Jun 30, 2024
d1af9d4
Testing.
Sep 8, 2024
a241248
Merge branch '2.x' into better_approach_to_memory_leaks_v2
Jan 3, 2025
e0e05c1
App resetter experimentation.
Jan 5, 2025
924fd9d
Cleans up reset logic.
Jan 5, 2025
395a7ff
Ignores line endings in tests.
Jan 5, 2025
8056951
Adds 'forget view engine' test.
Jan 5, 2025
943f25a
Laravel pint.
Jan 5, 2025
4687d48
Fixes str cache test with new Laravel version.
Jan 5, 2025
deb1411
Merge branch '2.x' into perf/application-snapshot
Jan 5, 2025
46a95c5
style.ci
Jan 5, 2025
599b853
style.ci
Jan 5, 2025
0307f79
Adds notice.
Jan 5, 2025
fd39022
Renames variables.
Jan 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes style ci.
  • Loading branch information
a.stecher committed May 15, 2024
commit e499184b9790aaebdefe2744520a503b56abaa59
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ public function handle($event): void
return;
}

with($event->sandbox->make(ChannelManager::class), function ($manager) use ($event) {
with($event->sandbox->make(ChannelManager::class), function ($manager) {
$manager->forgetDrivers();
});
}
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ public function test_the_notification_manager_drivers_should_be_flushed_on_reque
$channelManager = $app->make(ChannelManager::class);
$channelManager->driver();
$initialDriverCount = count($channelManager->getDrivers());
$app['router']->get('/first', fn() => 'Hello World');
$app['router']->get('/first', fn () => 'Hello World');

$worker->run();