Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify condition + remove workaround + require R 3.2 #168

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Jan 6, 2025

Great work on #167 !

I just wanted to send this to fine tune changes in #166

  • Including some simplifications of conditions (requires R 3.2 for anyNA())
  • Rename the vignette to labelled.Rmd to get a Get Started icon on the website (add a redirect)
  • Improve testing infra by requiring memisc to be installed in checks (currently, skipping tests) as pak doesn't install Enhances by default. Correction. It seems it is installed on the coverage action, but not on the check.
  • Removing workaround for dplyr::where() since it is now exported
  • .data is already imported from rlang
  • Address a tidyselect deprecation warning. (an external selection must be wrapped with all_of().
  • Remove partial matching in tests
  • Use across() and where() in example

@olivroy olivroy changed the title Minor updates Simplify condition + remove workaround + require R 3.2 Jan 6, 2025
@larmarange
Copy link
Owner

Thank you very much

@larmarange larmarange merged commit 236bb0b into larmarange:main Jan 6, 2025
8 checks passed
@olivroy olivroy deleted the check-fol branch January 6, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants