Add FileRender component #1576

btzr-io · 2018-06-11T06:44:31Z

Changes

Fix Review isPlayable() function Review isPlayable() function #1590
Use router pattern for rendering file viewer Use router pattern for rendering file viewer #1544
Initial step for Better preview for content #620
Add pdf-viewer to actually test something. Add file types support for E-Book #1701

Todo

Improve file type detection.
Fix getMediaType logic Fix getMediaType logic lbry-redux#51
Rename: video -> FileViewer

neb-b

Small changes

neb-b · 2018-06-18T21:18:51Z

src/renderer/component/video/internal/play-button.jsx

-    const icon = doesPlayback ? 'Play' : 'Folder';
-    const label = doesPlayback ? 'Play' : 'View';
+    const icon = doesPlayback ? 'Play' : 'Eye';
+    const label = doesPlayback ? 'Play' : 'Preview';


Can you change these to use the icon constants?

kauffj · 2018-06-25T14:15:53Z

src/renderer/constants/icons.js

@@ -26,3 +26,5 @@ export const HEART = 'Heart';
 export const UNLOCK = 'Unlock';
 export const CHECK_SIMPLE = 'Check';
 export const GLOBE = 'Globe';
+export const EYE = 'Eye';


This prompted: #1683

(not necessary to resolve before merging this)

btzr-io · 2018-06-27T16:13:33Z

Initial step for #620

neb-b · 2018-06-28T04:34:06Z

src/renderer/component/video/internal/player.jsx


 class VideoPlayer extends React.PureComponent {
  static MP3_CONTENT_TYPES = ['audio/mpeg3', 'audio/mpeg'];
+  static FILE_MEDIA_TYPES = ['3D-file', 'e-book', 'comic-book'];


Is comic-book an actual media type?

Oh I'm guessing this is just for future file types.

neb-b

Left a few more comments, not sure if all of them warrant changes.

Tom and I will be doing more testing on this tomorrow, with a lot of file types. Should be able to get it merged in the next day or two. Great work!

neb-b · 2018-06-28T04:35:44Z

src/renderer/component/video/internal/player.jsx

    const noMetadataMessage = 'Waiting for metadata.';
    const unplayableMessage = "Sorry, looks like we can't play this file.";
-    const hideMedia = this.playableType() && !hasMetadata && !unplayable;
+    const unsupportedMessage = "Sorry, looks like we can't preview this file.";
+    const isLoadingFile = !fileSource && this.fileType();


Since we are calling this.fileType() 3 times in 5 lines, lets just set it to a variable and use that for these checks below.

neb-b · 2018-06-28T05:09:47Z

src/renderer/component/video/internal/player.jsx

+        {isLoadingMetadata && <LoadingScreen status={noMetadataMessage} />}
+        {isUnplayable && <LoadingScreen status={unplayableMessage} spinner={false} />}
+        {unsupported ||
+          (isUnsupported && <LoadingScreen status={unsupportedMessage} spinner={false} />)}


I think this would be easier to follow if we had a shouldDisplayLoadingScreen() function or something.

const [isLoading, loadingStatus] = this.shouldDisplayLoadingScreen()

Then we would just need one LoadingScreen component

neb-b · 2018-06-28T05:13:46Z

src/renderer/component/video/internal/player.jsx


 class VideoPlayer extends React.PureComponent {
  static MP3_CONTENT_TYPES = ['audio/mpeg3', 'audio/mpeg'];
+  static FILE_MEDIA_TYPES = ['3D-file', 'e-book', 'comic-book'];


Oh I'm guessing this is just for future file types.

neb-b · 2018-06-28T05:16:17Z

src/renderer/component/video/internal/player.jsx

+    // Render custom viewer: FileRender
+    if (this.fileType()) this.renderFile();
+    // Render default viewer: render-media (video, audio, img, iframe)
+    else if (this.supportedType()) {


Should this be an if, else if, else statement instead?

It looks like it could call renderAudio and the default viewer both.

- Update fileRender logic - Fix missing file source

- Add new icon Eye - Show preview button

reduce lbry.getMedia calls update fileRender logic

unblock unplayable files fix context menu errors of pdfViwer

lbry-bot assigned neb-b Jun 11, 2018

btzr-io requested a review from neb-b June 11, 2018 06:44

lbry-bot assigned neb-b and unassigned neb-b Jun 11, 2018

btzr-io requested a review from kauffj June 11, 2018 06:44

lbry-bot assigned kauffj and neb-b and unassigned neb-b Jun 11, 2018

btzr-io mentioned this pull request Jun 11, 2018

add FileRender component #1554

Closed

btzr-io mentioned this pull request Jun 18, 2018

Revert "fixed isPlayable to only play for video or audio." #1632

Merged

lbry-bot unassigned neb-b Jun 18, 2018

neb-b suggested changes Jun 18, 2018

View reviewed changes

btzr-io unassigned kauffj Jun 20, 2018

lbry-bot assigned kauffj Jun 20, 2018

btzr-io requested a review from neb-b June 22, 2018 00:30

lbry-bot assigned neb-b and unassigned kauffj Jun 22, 2018

kauffj reviewed Jun 25, 2018

View reviewed changes

tzarebczan mentioned this pull request Jun 25, 2018

Web Content Should Open in a Web Type View #1682

Open

neb-b mentioned this pull request Jun 27, 2018

Add 3D-file-viewer component #1558

Merged

12 tasks

lbry-bot unassigned neb-b Jun 28, 2018

neb-b reviewed Jun 28, 2018

View reviewed changes

lbry-bot assigned neb-b and unassigned neb-b Jun 28, 2018

neb-b suggested changes Jun 28, 2018

View reviewed changes

lbry-bot assigned neb-b Jun 28, 2018

btzr-io mentioned this pull request Jul 4, 2018

Fix getMediaType logic lbryio/lbry-redux#51

Merged

btzr-io added the on hold Temporarily paused label Jul 5, 2018

btzr-io force-pushed the file-preview branch from f9251e8 to 5e1d6c2 Compare July 8, 2018 22:00

btzr-io requested a review from neb-b July 10, 2018 03:01

lbry-bot assigned neb-b and unassigned neb-b Jul 10, 2018

btzr-io removed the on hold Temporarily paused label Jul 10, 2018

btzr-io and others added 16 commits July 10, 2018 10:31

add fileRender component

a8edbee

more fixes

9b5ac83

- Update fileRender logic - Fix missing file source

add file-render.scss

a3a0299

import scss

78029ce

fix playable logic

f026ed6

- Add new icon Eye - Show preview button

use icon constants

213b528

rework loadingScreen logic

2afbda7

remove debug log

6b85467

add pdf-viewer

03c9e53

reduce lbry.getMedia calls update fileRender logic

more fixes

ec9448b

unblock unplayable files fix context menu errors of pdfViwer

fix pdfViewer css

e69dc3c

render file when download completed

bdf1634

wrap text strings in language function

1d8728c

update lbry-redux

624d869

improve mediaType detection

180cb7b

rename video component to fileViewer

0f09210

neb-b force-pushed the file-preview branch from 91566a6 to 0f09210 Compare July 10, 2018 14:34

neb-b approved these changes Jul 10, 2018

View reviewed changes

lbry-bot assigned neb-b and unassigned neb-b Jul 10, 2018

neb-b merged commit e317f57 into master Jul 10, 2018

btzr-io deleted the file-preview branch July 26, 2018 03:17

tzarebczan mentioned this pull request Aug 10, 2018

Use router pattern for rendering file viewer #1544

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add FileRender component #1576

Add FileRender component #1576

btzr-io commented Jun 11, 2018 •

edited

Loading

neb-b left a comment

neb-b Jun 18, 2018

btzr-io Jun 18, 2018

kauffj Jun 25, 2018

kauffj Jun 25, 2018

btzr-io commented Jun 27, 2018

neb-b Jun 28, 2018

neb-b Jun 28, 2018

btzr-io Jun 29, 2018

neb-b left a comment

neb-b Jun 28, 2018

neb-b Jun 28, 2018

neb-b Jun 28, 2018

neb-b Jun 28, 2018

Add FileRender component #1576

Add FileRender component #1576

Conversation

btzr-io commented Jun 11, 2018 • edited Loading

Changes

Todo

neb-b left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btzr-io commented Jun 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neb-b left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btzr-io commented Jun 11, 2018 •

edited

Loading