Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Touch Ups to TwoReactionArgon #105

Merged
merged 2 commits into from
May 24, 2023
Merged

[Docs] Touch Ups to TwoReactionArgon #105

merged 2 commits into from
May 24, 2023

Conversation

smpeyres
Copy link
Collaborator

Small pull-request, but following was done as discussed:

  • @ananthanarasimhanj pointed out error in simulation conditions table (wrong ionization coeff value) and problems with spline usage Interpolation #104 and reaction order Order of the reactions with the usage of EEDF #103. Error was fixed, spline was switched to linear, and warning was made for reaction order.
  • Re-ran input file with linear interpolation due to change of ionization rate coefficient.
  • Split the input file into chunks with accompanied text, rather than whole input file at top.
  • Added plasma density growth prediction to theory section and updated figure to show both initial rise prediction and steady state prediction with annotations, similar to ZDPlasKin.
  • Renaming of files for consistency and clarity.
  • Outline of ArgonMicrodischarge.rst (will be fleshed out next)

@smpeyres smpeyres requested a review from dcurreli May 24, 2023 14:13
Copy link
Contributor

@dcurreli dcurreli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dcurreli dcurreli merged commit d1dfc81 into lcpp-org:master May 24, 2023
MengnanLi91 added a commit to MengnanLi91/crane that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants