Update for API changes #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! ADParsedMaterials will be a great tool for Zapdos/Crane. (This also closes #53 , or at least makes it irrelevant.) |
|
Moose PR is in. I don't see a moose submodule here, so this can probably get merged. @lindsayad may know more on how to get Zapdos updated (do we need to manually update the crane submodule there?) |
Yeah, that's typically how we do it. Update crane, and then submit a PR to update the crane submodule in Zapdos. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed
ADFunctiontoSymFunctionto avoid confusion with upcoming AD'ified function objects.FunctionParserUtilsis now a template that takes a bool parameter, choosing between a regular and a dual number version (forward mode AD).This should probably get merged after idaholab/moose#15331 is in
Closes #57